Commit bd63f11f authored by Xiaomeng Tong's avatar Xiaomeng Tong Committed by Gerd Hoffmann
Browse files

virtio-gpu: fix a missing check to avoid NULL dereference 



'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset()
and it will lead to a NULL dereference by a lately use of it
(i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check.

Fixes: 62fb7a5e ("virtio-gpu: add 3d/virgl support")
Signed-off-by: default avatarXiaomeng Tong <xiam0nd.tong@gmail.com>
Reviewed-by: default avatarChia-I Wu <olvaffe@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220327050945.1614-1-xiam0nd.tong@gmail.com



[ kraxel: minor codestyle fixup ]

Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 6aed665f

drivers/gpu/drm/virtio/virtgpu_ioctl.c

+4 −2
Original line number Diff line number Diff line
@@ -580,8 +580,10 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev, 
	spin_unlock(&vgdev->display_info_lock);



	/* not in cache - need to talk to hw */

	virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,

	ret = virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,

					&cache_ent);

	if (ret)

		return ret;

	virtio_gpu_notify(vgdev);



copy_exit: