Commit bd574889 authored May 24, 2023 by Mirsad Goran Todorovac Committed by Takashi Iwai Jun 05, 2023

selftests: alsa: pcm-test: Fix compiler warnings about the format

GCC 11.3.0 issues warnings in this module about wrong sizes of format
specifiers:

pcm-test.c: In function ‘test_pcm_time’:
pcm-test.c:384:68: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 5 \
has type ‘unsigned int’ [-Wformat=]
384 | snprintf(msg, sizeof(msg), "rate mismatch %ld != %ld", rate, rrate);
pcm-test.c:455:53: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has \
type ‘long int’ [-Wformat=]
455 | "expected %d, wrote %li", rate, frames);
pcm-test.c:462:53: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has \
type ‘long int’ [-Wformat=]
462 | "expected %d, wrote %li", rate, frames);
pcm-test.c:467:53: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has \
type ‘long int’ [-Wformat=]
467 | "expected %d, wrote %li", rate, frames);

Simple fix according to compiler's suggestion removed the warnings.

Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230524191528.13203-1-mirsad.todorovac@alu.unizg.hr

Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 4ca110ca

tools/testing/selftests/alsa/pcm-test.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -381,7 +381,7 @@ static void test_pcm_time(struct pcm_data *data, enum test_class class,
		goto __close;
		}
		if (rrate != rate) {
		snprintf(msg, sizeof(msg), "rate mismatch %ld != %ld", rate, rrate);
		snprintf(msg, sizeof(msg), "rate mismatch %ld != %d", rate, rrate);
		goto __close;
		}
		rperiod_size = period_size;
		@@ -447,24 +447,24 @@ static void test_pcm_time(struct pcm_data *data, enum test_class class,
		frames = snd_pcm_writei(handle, samples, rate);
		if (frames < 0) {
		snprintf(msg, sizeof(msg),
		"Write failed: expected %d, wrote %li", rate, frames);
		"Write failed: expected %ld, wrote %li", rate, frames);
		goto __close;
		}
		if (frames < rate) {
		snprintf(msg, sizeof(msg),
		"expected %d, wrote %li", rate, frames);
		"expected %ld, wrote %li", rate, frames);
		goto __close;
		}
		} else {
		frames = snd_pcm_readi(handle, samples, rate);
		if (frames < 0) {
		snprintf(msg, sizeof(msg),
		"expected %d, wrote %li", rate, frames);
		"expected %ld, wrote %li", rate, frames);
		goto __close;
		}
		if (frames < rate) {
		snprintf(msg, sizeof(msg),
		"expected %d, wrote %li", rate, frames);
		"expected %ld, wrote %li", rate, frames);
		goto __close;
		}
		}