Commit bd379a21 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: replace the GetFrameSubType call 



The driver's local GetFrameSubType macro returns both frame type and
subtype.

Use the ieee80211 framework to extract the two fields. This shows more
clearly that both type and subtype are read.

Convert everything to host endianness before we use bit operations.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220417102221.466524-3-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 59e8d56f

drivers/staging/r8188eu/core/rtw_mlme_ext.c

+2 −3
Original line number Diff line number Diff line
@@ -395,7 +395,6 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame) 
	int index;

	struct mlme_handler *ptable;

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	u8 *pframe = precv_frame->rx_data;

	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)precv_frame->rx_data;

	struct sta_info *psta = rtw_get_stainfo(&padapter->stapriv, hdr->addr2);
@@ -409,8 +408,8 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame) 


	ptable = mlme_sta_tbl;



	index = GetFrameSubType(pframe) >> 4;



	index = (le16_to_cpu(hdr->frame_control) &

		 (IEEE80211_FCTL_STYPE | IEEE80211_FCTL_FTYPE)) >> 4;

	if (index > 13)

		return;

	ptable += index;