Commit bd1ffe8e authored by Wojciech Drewek's avatar Wojciech Drewek Committed by Tony Nguyen
Browse files

ice: return ENOSPC when exceeding ICE_MAX_CHAIN_WORDS 



When number of words exceeds ICE_MAX_CHAIN_WORDS, -ENOSPC
should be returned not -EINVAL. Do not overwrite this
error code in ice_add_tc_flower_adv_fltr.

Signed-off-by: default avatarWojciech Drewek <wojciech.drewek@intel.com>
Suggested-by: default avatarMarcin Szycik <marcin.szycik@linux.intel.com>
Acked-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: default avatarSandeep Penigalapati <sandeep.penigalapati@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 295819b5

drivers/net/ethernet/intel/ice/ice_switch.c

+4 −1
Original line number Diff line number Diff line
@@ -5992,9 +5992,12 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups, 
				word_cnt++;

	}



	if (!word_cnt || word_cnt > ICE_MAX_CHAIN_WORDS)

	if (!word_cnt)

		return -EINVAL;



	if (word_cnt > ICE_MAX_CHAIN_WORDS)

		return -ENOSPC;



	/* locate a dummy packet */

	profile = ice_find_dummy_packet(lkups, lkups_cnt, rinfo->tun_type);

drivers/net/ethernet/intel/ice/ice_tc_lib.c

+0 −1
Original line number Diff line number Diff line
@@ -622,7 +622,6 @@ ice_add_tc_flower_adv_fltr(struct ice_vsi *vsi, 
	} else if (ret) {

		NL_SET_ERR_MSG_MOD(tc_fltr->extack,

				   "Unable to add filter due to error");

		ret = -EIO;

		goto exit;

	}