Commit bd1e336a authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

driver core: platform: Remove platform_device_add_properties() 



There are no more users for it. The last place where it's
called is in platform_device_register_full(). Replacing that
call with device_create_managed_software_node() and
removing the function.

Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20210817102449.39994-3-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6d6e03db

drivers/base/platform.c

+2 −18
Original line number Diff line number Diff line
@@ -641,22 +641,6 @@ int platform_device_add_data(struct platform_device *pdev, const void *data, 
}

EXPORT_SYMBOL_GPL(platform_device_add_data);



/**

 * platform_device_add_properties - add built-in properties to a platform device

 * @pdev: platform device to add properties to

 * @properties: null terminated array of properties to add

 *

 * The function will take deep copy of @properties and attach the copy to the

 * platform device. The memory associated with properties will be freed when the

 * platform device is released.

 */

int platform_device_add_properties(struct platform_device *pdev,

				   const struct property_entry *properties)

{

	return device_add_properties(&pdev->dev, properties);

}

EXPORT_SYMBOL_GPL(platform_device_add_properties);



/**

 * platform_device_add - add a platform device to device hierarchy

 * @pdev: platform device we're adding
@@ -842,8 +826,8 @@ struct platform_device *platform_device_register_full( 
		goto err;



	if (pdevinfo->properties) {

		ret = platform_device_add_properties(pdev,

						     pdevinfo->properties);

		ret = device_create_managed_software_node(&pdev->dev,

							  pdevinfo->properties, NULL);

		if (ret)

			goto err;

	}

include/linux/platform_device.h

+0 −2
Original line number Diff line number Diff line
@@ -197,8 +197,6 @@ extern int platform_device_add_resources(struct platform_device *pdev, 
					 unsigned int num);

extern int platform_device_add_data(struct platform_device *pdev,

				    const void *data, size_t size);

extern int platform_device_add_properties(struct platform_device *pdev,

				const struct property_entry *properties);

extern int platform_device_add(struct platform_device *pdev);

extern void platform_device_del(struct platform_device *pdev);

extern void platform_device_put(struct platform_device *pdev);