Commit bd04b919 authored by Xiubo Li's avatar Xiubo Li Committed by Ilya Dryomov
Browse files

ceph: fail the open_by_handle_at() if the dentry is being unlinked 

When unlinking a file the kclient will send a unlink request to MDS
by holding the dentry reference, and then the MDS will return 2 replies,
which are unsafe reply and a deferred safe reply.

After the unsafe reply received the kernel will return and succeed
the unlink request to user space apps.

Only when the safe reply received the dentry's reference will be
released. Or the dentry will only be unhashed from dcache. But when
the open_by_handle_at() begins to open the unlinked files it will
succeed.

The inode->i_count couldn't be used to check whether the inode is
opened or not.

Link: https://tracker.ceph.com/issues/56524


Signed-off-by: default avatarXiubo Li <xiubli@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Reviewed-by: default avatarLuís Henriques <lhenriques@suse.de>
Tested-by: default avatarLuís Henriques <lhenriques@suse.de>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent b4b924c7

fs/ceph/export.c

+2 −1
Original line number Diff line number Diff line
@@ -181,6 +181,7 @@ struct inode *ceph_lookup_inode(struct super_block *sb, u64 ino) 
static struct dentry *__fh_to_dentry(struct super_block *sb, u64 ino)

{

	struct inode *inode = __lookup_inode(sb, ino);

	struct ceph_inode_info *ci = ceph_inode(inode);

	int err;



	if (IS_ERR(inode))
@@ -192,7 +193,7 @@ static struct dentry *__fh_to_dentry(struct super_block *sb, u64 ino) 
		return ERR_PTR(err);

	}

	/* -ESTALE if inode as been unlinked and no file is open */

	if ((inode->i_nlink == 0) && (atomic_read(&inode->i_count) == 1)) {

	if ((inode->i_nlink == 0) && !__ceph_is_file_opened(ci)) {

		iput(inode);

		return ERR_PTR(-ESTALE);

	}