Commit bcfa6be2 authored by XueBing Chen's avatar XueBing Chen Committed by Daniel Vetter
Browse files

dma-buf/sync_file: use strscpy to replace strlcpy 



The strlcpy should not be used because it doesn't limit the source
length. Preferred is strscpy.

Signed-off-by: default avatarXueBing Chen <chenxuebing@jari.cn>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/6aad3bff.d1a.181b982d1b1.Coremail.chenxuebing@jari.cn
parent 7350b2a3

drivers/dma-buf/sync_file.c

+4 −4
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ EXPORT_SYMBOL(sync_file_get_fence); 
char *sync_file_get_name(struct sync_file *sync_file, char *buf, int len)

{

	if (sync_file->user_name[0]) {

		strlcpy(buf, sync_file->user_name, len);

		strscpy(buf, sync_file->user_name, len);

	} else {

		struct dma_fence *fence = sync_file->fence;
@@ -172,7 +172,7 @@ static struct sync_file *sync_file_merge(const char *name, struct sync_file *a, 
		return NULL;

	}

	sync_file->fence = fence;

	strlcpy(sync_file->user_name, name, sizeof(sync_file->user_name));

	strscpy(sync_file->user_name, name, sizeof(sync_file->user_name));

	return sync_file;

}
@@ -262,9 +262,9 @@ static long sync_file_ioctl_merge(struct sync_file *sync_file, 
static int sync_fill_fence_info(struct dma_fence *fence,

				 struct sync_fence_info *info)

{

	strlcpy(info->obj_name, fence->ops->get_timeline_name(fence),

	strscpy(info->obj_name, fence->ops->get_timeline_name(fence),

		sizeof(info->obj_name));

	strlcpy(info->driver_name, fence->ops->get_driver_name(fence),

	strscpy(info->driver_name, fence->ops->get_driver_name(fence),

		sizeof(info->driver_name));



	info->status = dma_fence_get_status(fence);