Commit bcec04b3 authored by ChanWoo Lee's avatar ChanWoo Lee Committed by Martin K. Petersen
Browse files

scsi: ufs: ufs-qcom: Remove unneeded code 

Checks information about tx_lanes, but is not used.

Since commit 1e1e465c ("scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls
from host"), tx_lanes is deprecated.

As a result, ufs_qcom_link_startup_notify -> POST_CHANGE action does
nothing.  If it is not going to be updated, it can be removed.

Link: https://lore.kernel.org/r/20220627235545.16943-1-cw9316.lee@samsung.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarChanWoo Lee <cw9316.lee@samsung.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent df1ea242

drivers/ufs/host/ufs-qcom.c

+0 −23
Original line number Diff line number Diff line
@@ -58,19 +58,6 @@ static void ufs_qcom_dump_regs_wrapper(struct ufs_hba *hba, int offset, int len, 
	ufshcd_dump_regs(hba, offset, len * 4, prefix);

}



static int ufs_qcom_get_connected_tx_lanes(struct ufs_hba *hba, u32 *tx_lanes)

{

	int err = 0;



	err = ufshcd_dme_get(hba,

			UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), tx_lanes);

	if (err)

		dev_err(hba->dev, "%s: couldn't read PA_CONNECTEDTXDATALANES %d\n",

				__func__, err);



	return err;

}



static int ufs_qcom_host_clk_get(struct device *dev,

		const char *name, struct clk **clk_out, bool optional)

{
@@ -194,13 +181,6 @@ static int ufs_qcom_init_lane_clks(struct ufs_qcom_host *host) 
	return err;

}



static int ufs_qcom_link_startup_post_change(struct ufs_hba *hba)

{

	u32 tx_lanes;



	return ufs_qcom_get_connected_tx_lanes(hba, &tx_lanes);

}



static int ufs_qcom_check_hibern8(struct ufs_hba *hba)

{

	int err;
@@ -569,9 +549,6 @@ static int ufs_qcom_link_startup_notify(struct ufs_hba *hba, 
		if (ufshcd_get_local_unipro_ver(hba) != UFS_UNIPRO_VER_1_41)

			err = ufshcd_disable_host_tx_lcc(hba);



		break;

	case POST_CHANGE:

		ufs_qcom_link_startup_post_change(hba);

		break;

	default:

		break;