Commit bcc85868 authored by Rob Herring's avatar Rob Herring Committed by Jakub Kicinski
Browse files

net: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Acked-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230310144716.1544083-1-robh@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b39212d5

drivers/net/mdio/of_mdio.c

+2 −2
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ bool of_mdiobus_child_is_phy(struct device_node *child) 
		return true;

	}



	if (!of_find_property(child, "compatible", NULL))

	if (!of_property_present(child, "compatible"))

		return true;



	return false;
@@ -203,7 +203,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) 
	/* auto scan for PHYs with empty reg property */

	for_each_available_child_of_node(np, child) {

		/* Skip PHYs with reg property set */

		if (of_find_property(child, "reg", NULL))

		if (of_property_present(child, "reg"))

			continue;



		for (addr = 0; addr < PHY_MAX_ADDR; addr++) {

drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, 
		sdio->drive_strength = val;



	/* make sure there are interrupts defined in the node */

	if (!of_find_property(np, "interrupts", NULL))

	if (!of_property_present(np, "interrupts"))

		return;



	irq = irq_of_parse_and_map(np, 0);