Unverified Commit bcae1631 authored Sep 28, 2020 by Kuninori Morimoto Committed by Mark Brown Sep 28, 2020

ASoC: soc-pcm: remove unneeded dev_err() for snd_soc_component_module/open()



snd_soc_component_module_get(), snd_soc_component_open() itself will
indicate error message, thus, soc_pcm_components_open() don't need to
handle it.
This patch removes these.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87d026bwms.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent ce820145

sound/soc/soc-pcm.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -614,21 +614,13 @@ static int soc_pcm_components_open(struct snd_pcm_substream *substream)

		for_each_rtd_components(rtd, i, component) {
		ret = snd_soc_component_module_get_when_open(component, substream);
		if (ret < 0) {
		dev_err(component->dev,
		"ASoC: can't get module %s\n",
		component->name);
		if (ret < 0)
		break;
		}

		ret = snd_soc_component_open(component, substream);
		if (ret < 0) {
		dev_err(component->dev,
		"ASoC: can't open component %s: %d\n",
		component->name, ret);
		if (ret < 0)
		break;
		}
		}

		return ret;
		}