Commit bca3821d authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

net/sched: act_mpls: Add extack messages for offload failure 



For better error reporting to user space, add extack messages when mpls
action offload fails.

Example:

 # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable

 # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action mpls dec_ttl
 Error: cls_matchall: Failed to setup flow action.
 We have an error talking to the kernel

 # cat /sys/kernel/tracing/trace_pipe
       tc-182     [000] b..1.    18.693915: netlink_extack: msg=act_mpls: Offload not supported when "dec_ttl" option is used
       tc-182     [000] .....    18.693921: netlink_extack: msg=cls_matchall: Failed to setup flow action

Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4dcaa50d

net/sched/act_mpls.c

+7 −0
Original line number Diff line number Diff line
@@ -411,7 +411,14 @@ static int tcf_mpls_offload_act_setup(struct tc_action *act, void *entry_data, 
			entry->mpls_mangle.bos = tcf_mpls_bos(act);

			entry->mpls_mangle.ttl = tcf_mpls_ttl(act);

			break;

		case TCA_MPLS_ACT_DEC_TTL:

			NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"dec_ttl\" option is used");

			return -EOPNOTSUPP;

		case TCA_MPLS_ACT_MAC_PUSH:

			NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"mac_push\" option is used");

			return -EOPNOTSUPP;

		default:

			NL_SET_ERR_MSG_MOD(extack, "Unsupported MPLS mode offload");

			return -EOPNOTSUPP;

		}

		*index_inc = 1;