Commit bc792884 authored by Eric Farman's avatar Eric Farman Committed by Jens Axboe
Browse files

s390/dasd: Establish DMA alignment 



linux-next commit bf8d0853 ("iomap: add support for dma aligned
direct-io") changes the alignment requirement to come from the block
device rather than the block size, and the default alignment
requirement is 512-byte boundaries. Since DASD I/O has page
alignments for IDAW/TIDAW requests, let's override this value to
restore the expected behavior.

Make this change for both ECKD and DIAG disciplines, as they both
would fall into this category. Leave FBA alone, since it is always
comprised of 512-byte blocks.

Signed-off-by: default avatarEric Farman <farman@linux.ibm.com>
Acked-by: default avatarHalil Pasic <pasic@linux.ibm.com>
Reviewed-by: default avatarStefan Haberland <sth@linux.ibm.com>
Signed-off-by: default avatarStefan Haberland <sth@linux.ibm.com>
Link: https://lore.kernel.org/r/20220804213926.3361574-3-sth@linux.ibm.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent bcee43dc

drivers/s390/block/dasd_diag.c

+1 −0
Original line number Diff line number Diff line
@@ -639,6 +639,7 @@ static void dasd_diag_setup_blk_queue(struct dasd_block *block) 
	/* With page sized segments each segment can be translated into one idaw/tidaw */

	blk_queue_max_segment_size(q, PAGE_SIZE);

	blk_queue_segment_boundary(q, PAGE_SIZE - 1);

	blk_queue_dma_alignment(q, PAGE_SIZE - 1);

}



static int dasd_diag_pe_handler(struct dasd_device *device,

drivers/s390/block/dasd_eckd.c

+1 −0
Original line number Diff line number Diff line
@@ -6626,6 +6626,7 @@ static void dasd_eckd_setup_blk_queue(struct dasd_block *block) 
	/* With page sized segments each segment can be translated into one idaw/tidaw */

	blk_queue_max_segment_size(q, PAGE_SIZE);

	blk_queue_segment_boundary(q, PAGE_SIZE - 1);

	blk_queue_dma_alignment(q, PAGE_SIZE - 1);

}



static struct ccw_driver dasd_eckd_driver = {