Commit bc4e06c3 authored by Christian Marangi's avatar Christian Marangi Committed by Wen Zhiwei
Browse files

net: phy: Remove LED entry from LEDs list on unregister 

stable inclusion
from stable-v6.6.57
commit 143ffa7878e2d9d9c3836ee8304ce4930f7852a3
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IB2M97

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=143ffa7878e2d9d9c3836ee8304ce4930f7852a3



--------------------------------

commit f50b5d74c68e551667e265123659b187a30fe3a5 upstream.

Commit c938ab4d ("net: phy: Manual remove LEDs to ensure correct
ordering") correctly fixed a problem with using devm_ but missed
removing the LED entry from the LEDs list.

This cause kernel panic on specific scenario where the port for the PHY
is torn down and up and the kmod for the PHY is removed.

On setting the port down the first time, the assosiacted LEDs are
correctly unregistered. The associated kmod for the PHY is now removed.
The kmod is now added again and the port is now put up, the associated LED
are registered again.
On putting the port down again for the second time after these step, the
LED list now have 4 elements. With the first 2 already unregistered
previously and the 2 new one registered again.

This cause a kernel panic as the first 2 element should have been
removed.

Fix this by correctly removing the element when LED is unregistered.

Reported-by: default avatarDaniel Golle <daniel@makrotopia.org>
Tested-by: default avatarDaniel Golle <daniel@makrotopia.org>
Cc: stable@vger.kernel.org
Fixes: c938ab4d ("net: phy: Manual remove LEDs to ensure correct ordering")
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241004182759.14032-1-ansuelsmth@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarWen Zhiwei <wenzhiwei@kylinos.cn>
parent a90c3eae

drivers/net/phy/phy_device.c

+3 −2
Original line number Diff line number Diff line
@@ -3082,10 +3082,11 @@ static __maybe_unused int phy_led_hw_is_supported(struct led_classdev *led_cdev, 


static void phy_leds_unregister(struct phy_device *phydev)

{

	struct phy_led *phyled;

	struct phy_led *phyled, *tmp;



	list_for_each_entry(phyled, &phydev->leds, list) {

	list_for_each_entry_safe(phyled, tmp, &phydev->leds, list) {

		led_classdev_unregister(&phyled->led_cdev);

		list_del(&phyled->list);

	}

}