Commit bc433e5e authored by Stefano Garzarella's avatar Stefano Garzarella Committed by Michael S. Tsirkin
Browse files

vdpa_sim: cleanup kiovs in vdpasim_free() 



vringh_getdesc_iotlb() allocates memory to store the kvec, that
is freed with vringh_kiov_cleanup().

vringh_getdesc_iotlb() is able to reuse a kvec previously allocated,
so in order to avoid to allocate the kvec for each request, we are
not calling vringh_kiov_cleanup() when we finished to handle a
request, but we should call it when we free the entire device.

Acked-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/20210315163450.254396-8-sgarzare@redhat.com


Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 14c9ac05

drivers/vdpa/vdpa_sim/vdpa_sim.c

+7 −0
Original line number Diff line number Diff line
@@ -562,8 +562,15 @@ static int vdpasim_dma_unmap(struct vdpa_device *vdpa, u64 iova, u64 size) 
static void vdpasim_free(struct vdpa_device *vdpa)

{

	struct vdpasim *vdpasim = vdpa_to_sim(vdpa);

	int i;



	cancel_work_sync(&vdpasim->work);



	for (i = 0; i < vdpasim->dev_attr.nvqs; i++) {

		vringh_kiov_cleanup(&vdpasim->vqs[i].out_iov);

		vringh_kiov_cleanup(&vdpasim->vqs[i].in_iov);

	}



	put_iova_domain(&vdpasim->iova);

	iova_cache_put();

	kvfree(vdpasim->buffer);