Commit bc044414 authored Nov 16, 2022 by Xiu Jianfeng Committed by Steve French Dec 11, 2022

ksmbd: Fix resource leak in ksmbd_session_rpc_open()



When ksmbd_rpc_open() fails then it must call ksmbd_rpc_id_free() to
undo the result of ksmbd_ipc_id_alloc().

Fixes: e2f34481 ("cifsd: add server-side procedures for SMB3")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 30429388

fs/ksmbd/mgmt/user_session.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -108,15 +108,17 @@ int ksmbd_session_rpc_open(struct ksmbd_session sess, char rpc_name)
		entry->method = method;
		entry->id = ksmbd_ipc_id_alloc();
		if (entry->id < 0)
		goto error;
		goto free_entry;

		resp = ksmbd_rpc_open(sess, entry->id);
		if (!resp)
		goto error;
		goto free_id;

		kvfree(resp);
		return entry->id;
		error:
		free_id:
		ksmbd_rpc_id_free(entry->id);
		free_entry:
		list_del(&entry->list);
		kfree(entry);
		return -EINVAL;