Commit bbfdafa8 authored by Miaohe Lin's avatar Miaohe Lin Committed by Paolo Bonzini
Browse files

KVM: lib: use jump label to handle resource release in irq_bypass_register_producer() 



Use out_err jump label to handle resource release. It's a
good practice to release resource in one place and help
eliminate some duplicated code.

Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 8262fe85

virt/lib/irqbypass.c

+10 −9
Original line number Diff line number Diff line
@@ -85,6 +85,7 @@ int irq_bypass_register_producer(struct irq_bypass_producer *producer) 
{

	struct irq_bypass_producer *tmp;

	struct irq_bypass_consumer *consumer;

	int ret;



	if (!producer->token)

		return -EINVAL;
@@ -98,20 +99,16 @@ int irq_bypass_register_producer(struct irq_bypass_producer *producer) 


	list_for_each_entry(tmp, &producers, node) {

		if (tmp->token == producer->token) {

			mutex_unlock(&lock);

			module_put(THIS_MODULE);

			return -EBUSY;

			ret = -EBUSY;

			goto out_err;

		}

	}



	list_for_each_entry(consumer, &consumers, node) {

		if (consumer->token == producer->token) {

			int ret = __connect(producer, consumer);

			if (ret) {

				mutex_unlock(&lock);

				module_put(THIS_MODULE);

				return ret;

			}

			ret = __connect(producer, consumer);

			if (ret)

				goto out_err;

			break;

		}

	}
@@ -121,6 +118,10 @@ int irq_bypass_register_producer(struct irq_bypass_producer *producer) 
	mutex_unlock(&lock);



	return 0;

out_err:

	mutex_unlock(&lock);

	module_put(THIS_MODULE);

	return ret;

}

EXPORT_SYMBOL_GPL(irq_bypass_register_producer);