Commit bbfbf7a5 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

Revert "netfilter: conntrack: mark UDP zero checksum as CHECKSUM_UNNECESSARY" 



This reverts commit 5bed9f3f.

Gal Presman says:
 this patch broke geneve tunnels, or possibly all udp tunnels?
 A simple test that creates two geneve tunnels and runs tcp iperf fails
 and results in checksum errors (TcpInCsumErrors).

Original commit wanted to fix nf_reject with zero checksum,
so it appears better to change nf reject infra instead.

Fixes: 5bed9f3f ("netfilter: conntrack: mark UDP zero checksum as CHECKSUM_UNNECESSARY")
Reported-by: default avatarGal Pressman <gal@nvidia.com>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent ef132dc4

net/netfilter/nf_conntrack_proto_udp.c

+1 −3
Original line number Diff line number Diff line
@@ -63,10 +63,8 @@ static bool udp_error(struct sk_buff *skb, 
	}



	/* Packet with no checksum */

	if (!hdr->check) {

		skb->ip_summed = CHECKSUM_UNNECESSARY;

	if (!hdr->check)

		return false;

	}



	/* Checksum invalid? Ignore.

	 * We skip checking packets on the outgoing path