Commit bbf0b423 authored by Rustam Subkhankulov's avatar Rustam Subkhankulov Committed by Saeed Mahameed
Browse files

net/mlx5e: Removed useless code in function 



Comparison of eth_ft->ft with NULL is useless, because
get_flow_table() returns either pointer 'eth_ft'
such that eth_ft->ft != NULL, or an erroneous value that is
handled on return, causing mlx5e_ethtool_flow_replace()
to terminate before checking whether eth_ft->ft equals NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarRustam Subkhankulov <subkhankulov@ispras.ru>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 9c0ca9ba

drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c

+1 −4
Original line number Diff line number Diff line
@@ -742,10 +742,7 @@ mlx5e_ethtool_flow_replace(struct mlx5e_priv *priv, 


	eth_rule->flow_spec = *fs;

	eth_rule->eth_ft = eth_ft;

	if (!eth_ft->ft) {

		err = -EINVAL;

		goto del_ethtool_rule;

	}



	rule = add_ethtool_flow_rule(priv, eth_rule, eth_ft->ft, fs, rss_context);

	if (IS_ERR(rule)) {

		err = PTR_ERR(rule);