Commit bbeb18f2 authored by Anirudh Rayabharam's avatar Anirudh Rayabharam Committed by Greg Kroah-Hartman
Browse files

net/smc: properly handle workqueue allocation failure 



In smcd_alloc_dev(), if alloc_ordered_workqueue() fails, properly catch
it, clean up and return NULL to let the caller know there was a failure.
Move the call to alloc_ordered_workqueue higher in the function in order
to abort earlier without needing to unwind the call to device_initialize().

Cc: Ursula Braun <ubraun@linux.ibm.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarAnirudh Rayabharam <mail@anirudhrb.com>
Link: https://lore.kernel.org/r/20210503115736.2104747-18-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5369ead8

net/smc/smc_ism.c

+8 −2
Original line number Diff line number Diff line
@@ -402,6 +402,14 @@ struct smcd_dev *smcd_alloc_dev(struct device *parent, const char *name, 
		return NULL;

	}



	smcd->event_wq = alloc_ordered_workqueue("ism_evt_wq-%s)",

						 WQ_MEM_RECLAIM, name);

	if (!smcd->event_wq) {

		kfree(smcd->conn);

		kfree(smcd);

		return NULL;

	}



	smcd->dev.parent = parent;

	smcd->dev.release = smcd_release;

	device_initialize(&smcd->dev);
@@ -415,8 +423,6 @@ struct smcd_dev *smcd_alloc_dev(struct device *parent, const char *name, 
	INIT_LIST_HEAD(&smcd->vlan);

	INIT_LIST_HEAD(&smcd->lgr_list);

	init_waitqueue_head(&smcd->lgrs_deleted);

	smcd->event_wq = alloc_ordered_workqueue("ism_evt_wq-%s)",

						 WQ_MEM_RECLAIM, name);

	return smcd;

}

EXPORT_SYMBOL_GPL(smcd_alloc_dev);