Commit bbea126c authored Nov 04, 2020 by Ido Schimmel Committed by Jakub Kicinski Nov 06, 2020

nexthop: Remove in-kernel route notifications when nexthop changes



Remove in-kernel route notifications when the configuration of their
nexthop changes.

These notifications are unnecessary because the route still uses the
same nexthop ID. A separate notification for the nexthop change itself
is now sent in the nexthop notification chain.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 975ff7f3

net/ipv4/fib_trie.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -2100,15 +2100,6 @@ static void __fib_info_notify_update(struct net net, struct fib_table tb,
		rtmsg_fib(RTM_NEWROUTE, htonl(n->key), fa,
		KEYLENGTH - fa->fa_slen, tb->tb_id,
		info, NLM_F_REPLACE);

		/* call_fib_entry_notifiers will be removed when
		* in-kernel notifier is implemented and supported
		* for nexthop objects
		*/
		call_fib_entry_notifiers(net, FIB_EVENT_ENTRY_REPLACE,
		n->key,
		KEYLENGTH - fa->fa_slen, fa,
		NULL);
		}
		}
		}

net/ipv6/route.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -6039,11 +6039,6 @@ void fib6_rt_update(struct net net, struct fib6_info rt,
		struct sk_buff *skb;
		int err = -ENOBUFS;

		/* call_fib6_entry_notifiers will be removed when in-kernel notifier
		* is implemented and supported for nexthop objects
		*/
		call_fib6_entry_notifiers(net, FIB_EVENT_ENTRY_REPLACE, rt, NULL);

		skb = nlmsg_new(rt6_nlmsg_size(rt), gfp_any());
		if (!skb)
		goto errout;