Commit bbdcf516 authored by Thierry Reding's avatar Thierry Reding
Browse files

drm/dsi: Order DCS helpers by command code 



Most of these helpers had been introduced in the correct order, but some
were simply appended, which wasn't detected when they were applied.

Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 29b4817d

drivers/gpu/drm/drm_mipi_dsi.c

+17 −17
Original line number Diff line number Diff line
@@ -999,47 +999,47 @@ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, 
EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on);



/**

 * mipi_dsi_dcs_set_tear_scanline() - set the scanline to use as trigger for

 *    the Tearing Effect output signal of the display module

 * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image

 *    data used by the interface

 * @dsi: DSI peripheral device

 * @scanline: scanline to use as trigger

 * @format: pixel format

 *

 * Return: 0 on success or a negative error code on failure

 * Return: 0 on success or a negative error code on failure.

 */

int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline)

int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format)

{

	u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, scanline >> 8,

			  scanline & 0xff };

	ssize_t err;



	err = mipi_dsi_generic_write(dsi, payload, sizeof(payload));

	err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_PIXEL_FORMAT, &format,

				 sizeof(format));

	if (err < 0)

		return err;



	return 0;

}

EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline);

EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format);



/**

 * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image

 *    data used by the interface

 * mipi_dsi_dcs_set_tear_scanline() - set the scanline to use as trigger for

 *    the Tearing Effect output signal of the display module

 * @dsi: DSI peripheral device

 * @format: pixel format

 * @scanline: scanline to use as trigger

 *

 * Return: 0 on success or a negative error code on failure.

 * Return: 0 on success or a negative error code on failure

 */

int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format)

int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline)

{

	u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, scanline >> 8,

			  scanline & 0xff };

	ssize_t err;



	err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_PIXEL_FORMAT, &format,

				 sizeof(format));

	err = mipi_dsi_generic_write(dsi, payload, sizeof(payload));

	if (err < 0)

		return err;



	return 0;

}

EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format);

EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline);



static int mipi_dsi_drv_probe(struct device *dev)

{

include/drm/drm_mipi_dsi.h

+1 −1
Original line number Diff line number Diff line
@@ -265,11 +265,11 @@ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, 
				    u16 end);

int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start,

				  u16 end);

int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline);

int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi);

int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi,

			     enum mipi_dsi_dcs_tear_mode mode);

int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format);

int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline);



/**

 * struct mipi_dsi_driver - DSI driver