Commit bbdb3c5d authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

blk-mq: remove dead check from blk_mq_dispatch_rq_list 



When BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE is returned from
.queue_rq, the 'list' variable always holds this rq which isn't
queued to LLD successfully.

So blk_mq_dispatch_rq_list() always returns false from the branch
of '!list_empty(list)'.

No functional change.

Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Tested-by: default avatarBaolin Wang <baolin.wang7@gmail.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@infradead.org>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Baolin Wang <baolin.wang7@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 75383524

block/blk-mq.c

+0 −7
Original line number Diff line number Diff line
@@ -1426,13 +1426,6 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list, 
	} else

		blk_mq_update_dispatch_busy(hctx, false);



	/*

	 * If the host/device is unable to accept more work, inform the

	 * caller of that.

	 */

	if (ret == BLK_STS_RESOURCE || ret == BLK_STS_DEV_RESOURCE)

		return false;



	return (queued + errors) != 0;

}