Commit bbc8c3a4 authored by Philipp Hortmann's avatar Philipp Hortmann Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192e: Remove ftrace-like logging in r8192E_firmware.c, ... 



Remove "Unnecessary ftrace-like logging" as requested by checkpatch.

Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/370f47919a69f2f1717f50123c1617cabc78ceca.1663387785.git.philipp.g.hortmann@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 74adc1f0

drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c

+0 −6
Original line number Diff line number Diff line
@@ -115,10 +115,6 @@ bool rtl92e_config_rf(struct net_device *dev) 
						(enum rf90_radio_path)eRFPath,

						RegOffSetToBeCheck,

						bMask12Bits);

			RT_TRACE(COMP_RF,

				 "RF %d %d register final value: %x\n",

				 eRFPath, RegOffSetToBeCheck,

				 RF3_Final_Value);

			RetryTimes--;

		}
@@ -142,8 +138,6 @@ bool rtl92e_config_rf(struct net_device *dev) 
			goto fail;

		}

	}



	RT_TRACE(COMP_PHY, "PHY Initialization Success\n");

	return true;



fail:

drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c

+0 −2
Original line number Diff line number Diff line
@@ -21,8 +21,6 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data, 


	struct tx_fwinfo_8190pci *pTxFwInfo = NULL;



	RT_TRACE(COMP_CMDPKT, "%s(),buffer_len is %d\n", __func__, len);



	do {

		if ((len - frag_offset) > CMDPACKET_FRAG_SIZE) {

			frag_length = CMDPACKET_FRAG_SIZE;

drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c

+0 −7
Original line number Diff line number Diff line
@@ -77,10 +77,6 @@ static bool _rtl92e_fw_check_ready(struct net_device *dev, 
		rt_status = _rtl92e_wait_for_fw(dev, CPU_GEN_FIRM_RDY, 20);

		if (rt_status)

			pfirmware->status = FW_STATUS_5_READY;

		else

			RT_TRACE(COMP_FIRMWARE,

				 "_rtl92e_is_fw_ready fail(%d)!\n",

				 rt_status);

		break;

	default:

		rt_status = false;
@@ -149,9 +145,6 @@ bool rtl92e_init_fw(struct net_device *dev) 
	} else if (pfirmware->status == FW_STATUS_5_READY) {

		rst_opt = OPT_FIRMWARE_RESET;

		starting_state = FW_INIT_STEP2_DATA;

	} else {

		RT_TRACE(COMP_FIRMWARE,

			 "PlatformInitFirmware: undefined firmware state\n");

	}



	for (i = starting_state; i <= FW_INIT_STEP2_DATA; i++) {

drivers/staging/rtl8192e/rtl8192e/rtl_cam.c

+0 −16
Original line number Diff line number Diff line
@@ -46,10 +46,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) 
		ieee->hwsec_active = 0;

		SECR_value &= ~SCR_RxDecEnable;

	}



	RT_TRACE(COMP_SEC, "%s:, hwsec:%d, pairwise_key:%d, SECR_value:%x\n",

		 __func__, ieee->hwsec_active, ieee->pairwise_key_type,

		 SECR_value);

	rtl92e_writeb(dev, SECR, SECR_value);

}
@@ -60,10 +56,6 @@ void rtl92e_set_swcam(struct net_device *dev, u8 EntryNo, u8 KeyIndex, 
	struct r8192_priv *priv = rtllib_priv(dev);

	struct rtllib_device *ieee = priv->rtllib;



	RT_TRACE(COMP_DBG,

		 "===========>%s():EntryNo is %d,KeyIndex is %d,KeyType is %d,is_mesh is %d\n",

		 __func__, EntryNo, KeyIndex, KeyType, is_mesh);



	if (EntryNo >= TOTAL_CAM_ENTRY)

		return;
@@ -107,10 +99,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, 
		return;

	}



	RT_TRACE(COMP_SEC,

		 "====>to %s, dev:%p, EntryNo:%d, KeyIndex:%d,KeyType:%d, MacAddr %pM\n",

		 __func__, dev, EntryNo, KeyIndex, KeyType, MacAddr);



	if (DefaultKey)

		usConfig |= BIT15 | (KeyType<<2);

	else
@@ -144,7 +132,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, 
			}

		}

	}

	RT_TRACE(COMP_SEC, "=========>after set key, usconfig:%x\n", usConfig);

}



void rtl92e_cam_restore(struct net_device *dev)
@@ -163,9 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev) 
		0xff, 0xff, 0xff, 0xff, 0xff, 0xff

	};



	RT_TRACE(COMP_SEC, "%s:\n", __func__);





	if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) ||

	    (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) {

drivers/staging/rtl8192e/rtl8192e/rtl_pci.c

+0 −2
Original line number Diff line number Diff line
@@ -20,8 +20,6 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev, 


	pcie_capability_read_word(priv->pdev, PCI_EXP_LNKCTL, &LinkCtrlReg);



	RT_TRACE(COMP_INIT, "Link Control Register =%x\n", LinkCtrlReg);



	pci_read_config_byte(pdev, 0x98, &tmp);

	tmp |= BIT4;

	pci_write_config_byte(pdev, 0x98, tmp);