Commit bbb69e8b authored by Josh Poimboeuf's avatar Josh Poimboeuf Committed by Borislav Petkov
Browse files

x86/speculation: Use cached host SPEC_CTRL value for guest entry/exit 



There's no need to recalculate the host value for every entry/exit.
Just use the cached value in spec_ctrl_current().

Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
parent 56aa4d22

arch/x86/kernel/cpu/bugs.c

+1 −11
Original line number Original line Diff line number Diff line
@@ -208,7 +208,7 @@ void __init check_bugs(void) 
void

void

x86_virt_spec_ctrl(u64 guest_spec_ctrl, u64 guest_virt_spec_ctrl, bool setguest)

x86_virt_spec_ctrl(u64 guest_spec_ctrl, u64 guest_virt_spec_ctrl, bool setguest)

{

{

	u64 msrval, guestval, hostval = x86_spec_ctrl_base;

	u64 msrval, guestval, hostval = spec_ctrl_current();

	struct thread_info *ti = current_thread_info();

	struct thread_info *ti = current_thread_info();





	/* Is MSR_SPEC_CTRL implemented ? */

	/* Is MSR_SPEC_CTRL implemented ? */
@@ -221,15 +221,6 @@ x86_virt_spec_ctrl(u64 guest_spec_ctrl, u64 guest_virt_spec_ctrl, bool setguest) 
		guestval = hostval & ~x86_spec_ctrl_mask;

		guestval = hostval & ~x86_spec_ctrl_mask;

		guestval |= guest_spec_ctrl & x86_spec_ctrl_mask;

		guestval |= guest_spec_ctrl & x86_spec_ctrl_mask;





		/* SSBD controlled in MSR_SPEC_CTRL */

		if (static_cpu_has(X86_FEATURE_SPEC_CTRL_SSBD) ||

		    static_cpu_has(X86_FEATURE_AMD_SSBD))

			hostval |= ssbd_tif_to_spec_ctrl(ti->flags);



		/* Conditional STIBP enabled? */

		if (static_branch_unlikely(&switch_to_cond_stibp))

			hostval |= stibp_tif_to_spec_ctrl(ti->flags);



		if (hostval != guestval) {

		if (hostval != guestval) {

			msrval = setguest ? guestval : hostval;

			msrval = setguest ? guestval : hostval;

			wrmsrl(MSR_IA32_SPEC_CTRL, msrval);

			wrmsrl(MSR_IA32_SPEC_CTRL, msrval);
@@ -1397,7 +1388,6 @@ static void __init spectre_v2_select_mitigation(void) 
		pr_err(SPECTRE_V2_EIBRS_EBPF_MSG);

		pr_err(SPECTRE_V2_EIBRS_EBPF_MSG);





	if (spectre_v2_in_ibrs_mode(mode)) {

	if (spectre_v2_in_ibrs_mode(mode)) {

		/* Force it so VMEXIT will restore correctly */

		x86_spec_ctrl_base |= SPEC_CTRL_IBRS;

		x86_spec_ctrl_base |= SPEC_CTRL_IBRS;

		write_spec_ctrl_current(x86_spec_ctrl_base, true);

		write_spec_ctrl_current(x86_spec_ctrl_base, true);

	}

	}