Commit bba6c477 authored by Ahmad Fatoum's avatar Ahmad Fatoum Committed by Wim Van Sebroeck
Browse files

watchdog: f71808e_wdt: remove superfluous global 



max_timeout never served any purpose over WATCHDOG_MAX_TIMEOUT, which it
was initialized with. Drop it.

Suggested-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarAhmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/d1f8cda90283855633537adee0af2c6b00a9ec25.1628525954.git-series.a.fatoum@pengutronix.de


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 164483c7

drivers/watchdog/f71808e_wdt.c

+2 −3
Original line number Diff line number Diff line
@@ -81,7 +81,6 @@ static unsigned short force_id; 
module_param(force_id, ushort, 0);

MODULE_PARM_DESC(force_id, "Override the detected device ID");



static const int max_timeout = WATCHDOG_MAX_TIMEOUT;

static int timeout = WATCHDOG_TIMEOUT;	/* default timeout in seconds */

module_param(timeout, int, 0);

MODULE_PARM_DESC(timeout,
@@ -221,7 +220,7 @@ static inline void superio_exit(int base) 
static int watchdog_set_timeout(int timeout)

{

	if (timeout <= 0

	 || timeout >  max_timeout) {

	 || timeout >  WATCHDOG_MAX_TIMEOUT) {

		pr_err("watchdog timeout out of range\n");

		return -EINVAL;

	}
@@ -720,7 +719,7 @@ static int __init watchdog_init(int sioaddr) 


	if (start_withtimeout) {

		if (start_withtimeout <= 0

		 || start_withtimeout >  max_timeout) {

		 || start_withtimeout >  WATCHDOG_MAX_TIMEOUT) {

			pr_err("starting timeout out of range\n");

			err = -EINVAL;

			goto exit_miscdev;