Commit bb89e8ac authored by Luoyouming's avatar Luoyouming Committed by Zheng Zengkai
Browse files

RDMA/hns: Use a constant instead of sizeof operation 

driver inclusion
category: cleanup
bugzilla: https://gitee.com/openeuler/kernel/issues/I5USIG



-----------------------------------------------------------

The sge size is known to be constant, so it's unnecessary to use sizeof to
calculate.

Fixes: 30b70788 ("RDMA/hns: Support inline data in extented sge space for RC")

Signed-off-by: default avatarLuoyouming <luoyouming@huawei.com>
Reviewed-by: default avatarYangyang Li <liyangyang20@huawei.com>
Reviewed-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
parent e558d73c

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+3 −4
Original line number Diff line number Diff line
@@ -193,8 +193,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp, 
				 unsigned int *sge_idx, u32 msg_len)

{

	struct ib_device *ibdev = &(to_hr_dev(qp->ibqp.device))->ib_dev;

	unsigned int dseg_len = sizeof(struct hns_roce_v2_wqe_data_seg);

	unsigned int ext_sge_sz = qp->sq.max_gs * dseg_len;

	unsigned int ext_sge_sz = qp->sq.max_gs * HNS_ROCE_SGE_SIZE;

	unsigned int left_len_in_pg;

	unsigned int idx = *sge_idx;

	unsigned int i = 0;
@@ -222,7 +221,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp, 
		if (len <= left_len_in_pg) {

			memcpy(dseg, addr, len);



			idx += len / dseg_len;

			idx += len / HNS_ROCE_SGE_SIZE;



			i++;

			if (i >= wr->num_sge)
@@ -237,7 +236,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp, 


			len -= left_len_in_pg;

			addr += left_len_in_pg;

			idx += left_len_in_pg / dseg_len;

			idx += left_len_in_pg / HNS_ROCE_SGE_SIZE;

			dseg = hns_roce_get_extend_sge(qp,

						idx & (qp->sge.sge_cnt - 1));

			left_len_in_pg = 1 << HNS_HW_PAGE_SHIFT;