Commit bb7b1c9c authored by Dave Chinner's avatar Dave Chinner Committed by Dave Chinner
Browse files

xfs: tag transactions that contain intent done items 



Intent whiteouts will require extra work to be done during
transaction commit if the transaction contains an intent done item.

To determine if a transaction contains an intent done item, we want
to avoid having to walk all the items in the transaction to check if
they are intent done items. Hence when we add an intent done item to
a transaction, tag the transaction to indicate that it contains such
an item.

We don't tag the transaction when the defer ops is relogging an
intent to move it forward in the log. Whiteouts will never apply to
these cases, so we don't need to bother looking for them.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarAllison Henderson <allison.henderson@oracle.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent f5b81200

fs/xfs/libxfs/xfs_shared.h

+17 −7
Original line number Diff line number Diff line
@@ -54,13 +54,23 @@ void xfs_log_get_max_trans_res(struct xfs_mount *mp, 
/*

 * Values for t_flags.

 */

#define	XFS_TRANS_DIRTY		0x01	/* something needs to be logged */

#define	XFS_TRANS_SB_DIRTY	0x02	/* superblock is modified */

#define	XFS_TRANS_PERM_LOG_RES	0x04	/* xact took a permanent log res */

#define	XFS_TRANS_SYNC		0x08	/* make commit synchronous */

#define XFS_TRANS_RESERVE	0x20    /* OK to use reserved data blocks */

#define XFS_TRANS_NO_WRITECOUNT 0x40	/* do not elevate SB writecount */

#define XFS_TRANS_RES_FDBLKS	0x80	/* reserve newly freed blocks */

/* Transaction needs to be logged */

#define XFS_TRANS_DIRTY			(1u << 0)

/* Superblock is dirty and needs to be logged */

#define XFS_TRANS_SB_DIRTY		(1u << 1)

/* Transaction took a permanent log reservation */

#define XFS_TRANS_PERM_LOG_RES		(1u << 2)

/* Synchronous transaction commit needed */

#define XFS_TRANS_SYNC			(1u << 3)

/* Transaction can use reserve block pool */

#define XFS_TRANS_RESERVE		(1u << 4)

/* Transaction should avoid VFS level superblock write accounting */

#define XFS_TRANS_NO_WRITECOUNT		(1u << 5)

/* Transaction has freed blocks returned to it's reservation */

#define XFS_TRANS_RES_FDBLKS		(1u << 6)

/* Transaction contains an intent done log item */

#define XFS_TRANS_HAS_INTENT_DONE	(1u << 7)



/*

 * LOWMODE is used by the allocator to activate the lowspace algorithm - when

 * free space is running low the extent allocator may choose to allocate an

fs/xfs/xfs_bmap_item.c

+1 −1
Original line number Diff line number Diff line
@@ -257,7 +257,7 @@ xfs_trans_log_finish_bmap_update( 
	 * 1.) releases the BUI and frees the BUD

	 * 2.) shuts down the filesystem

	 */

	tp->t_flags |= XFS_TRANS_DIRTY;

	tp->t_flags |= XFS_TRANS_DIRTY | XFS_TRANS_HAS_INTENT_DONE;

	set_bit(XFS_LI_DIRTY, &budp->bud_item.li_flags);



	return error;

fs/xfs/xfs_extfree_item.c

+1 −1
Original line number Diff line number Diff line
@@ -381,7 +381,7 @@ xfs_trans_free_extent( 
	 * 1.) releases the EFI and frees the EFD

	 * 2.) shuts down the filesystem

	 */

	tp->t_flags |= XFS_TRANS_DIRTY;

	tp->t_flags |= XFS_TRANS_DIRTY | XFS_TRANS_HAS_INTENT_DONE;

	set_bit(XFS_LI_DIRTY, &efdp->efd_item.li_flags);



	next_extent = efdp->efd_next_extent;

fs/xfs/xfs_refcount_item.c

+1 −1
Original line number Diff line number Diff line
@@ -262,7 +262,7 @@ xfs_trans_log_finish_refcount_update( 
	 * 1.) releases the CUI and frees the CUD

	 * 2.) shuts down the filesystem

	 */

	tp->t_flags |= XFS_TRANS_DIRTY;

	tp->t_flags |= XFS_TRANS_DIRTY | XFS_TRANS_HAS_INTENT_DONE;

	set_bit(XFS_LI_DIRTY, &cudp->cud_item.li_flags);



	return error;

fs/xfs/xfs_rmap_item.c

+1 −1
Original line number Diff line number Diff line
@@ -330,7 +330,7 @@ xfs_trans_log_finish_rmap_update( 
	 * 1.) releases the RUI and frees the RUD

	 * 2.) shuts down the filesystem

	 */

	tp->t_flags |= XFS_TRANS_DIRTY;

	tp->t_flags |= XFS_TRANS_DIRTY | XFS_TRANS_HAS_INTENT_DONE;

	set_bit(XFS_LI_DIRTY, &rudp->rud_item.li_flags);



	return error;