Commit bb6e8c28 authored by Luis Chamberlain's avatar Luis Chamberlain Committed by Greg Kroah-Hartman
Browse files

firmware_loader: simplfy builtin or module check 



The existing check is outdated and confuses developers. Use the
already existing IS_REACHABLE() defined on kconfig.h which makes
the intention much clearer.

Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Reported-by: default avatarBorislav Petkov <bp@alien8.de>
Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
Ackd-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20220112160053.723795-1-mcgrof@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8f2d1160

include/linux/firmware.h

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ static inline bool firmware_request_builtin(struct firmware *fw, 
}

#endif



#if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE))

#if IS_REACHABLE(CONFIG_FW_LOADER)

int request_firmware(const struct firmware **fw, const char *name,

		     struct device *device);

int firmware_request_nowarn(const struct firmware **fw, const char *name,