Commit bb6886bf authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman
Browse files

misc: lis3lv02d: Change lis3lv02d_init_device() return value for unknown sensors to -ENODEV 



Modern HP laptops do not necessarily actually contain a lis3lv02d
sensor, yet they still define a HPQ6007 device in there ACPI tables.

This leads to the following messages being logged in dmesg:

[   17.376342] hp_accel: laptop model unknown, using default axes configuration
[   17.399766] lis3lv02d: unknown sensor type 0x0
[   17.399804] hp_accel: probe of HPQ6007:00 failed with error -22

The third message is unnecessary and does not provide any useful info,
change the return value for unknown sensors to -ENODEV. This is the
proper return value to indicate that the driver will not be handling the
device and it silences the pr_warn printing the third message.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199715
Link: https://lore.kernel.org/r/20210217102501.31758-2-hdegoede@redhat.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3641762c

drivers/misc/lis3lv02d/lis3lv02d.c

+1 −1
Original line number Diff line number Diff line
@@ -1173,7 +1173,7 @@ int lis3lv02d_init_device(struct lis3lv02d *lis3) 
		break;

	default:

		pr_err("unknown sensor type 0x%X\n", lis3->whoami);

		return -EINVAL;

		return -ENODEV;

	}



	lis3->reg_cache = kzalloc(max(sizeof(lis3_wai8_regs),