Commit bb42b7e9 authored Jun 27, 2022 by Yang Yingliang Committed by Alexandre Belloni Jul 26, 2022

rtc: rv8803: fix missing unlock on error in rv8803_set_time()



Add the missing unlock before return from function rv8803_set_time()
in the error handling case.

Fixes: f8176e0b ("rtc: rv8803: initialize registers on post-probe voltage loss")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220627080822.3881072-1-yangyingliang@huawei.com

parent 07dcc6f9

drivers/rtc/rtc-rv8803.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -315,9 +315,11 @@ static int rv8803_set_time(struct device dev, struct rtc_time tm)

	if (flags & RV8803_FLAG_V2F) {		if (flags & RV8803_FLAG_V2F) {
	ret = rv8803_regs_reset(rv8803);		ret = rv8803_regs_reset(rv8803);
	if (ret)		if (ret) {
			mutex_unlock(&rv8803->flags_lock);
	return ret;		return ret;
	}		}
			}

	ret = rv8803_write_reg(rv8803->client, RV8803_FLAG,		ret = rv8803_write_reg(rv8803->client, RV8803_FLAG,
	flags & ~(RV8803_FLAG_V1F \| RV8803_FLAG_V2F));		flags & ~(RV8803_FLAG_V1F \| RV8803_FLAG_V2F));