Commit bb30b453 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Takashi Iwai
Browse files

ALSA: x86: intel_hdmi_audio: use pm_runtime_resume_and_get() 



The current code does not check for errors and does not release the
reference on errors.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20220616222910.136854-3-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e87c65ae

sound/x86/intel_hdmi_audio.c

+8 −2
Original line number Diff line number Diff line
@@ -1068,7 +1068,9 @@ static int had_pcm_open(struct snd_pcm_substream *substream) 
	intelhaddata = snd_pcm_substream_chip(substream);

	runtime = substream->runtime;



	pm_runtime_get_sync(intelhaddata->dev);

	retval = pm_runtime_resume_and_get(intelhaddata->dev);

	if (retval < 0)

		return retval;



	/* set the runtime hw parameter with local snd_pcm_hardware struct */

	runtime->hw = had_pcm_hardware;
@@ -1536,8 +1538,12 @@ static void had_audio_wq(struct work_struct *work) 
		container_of(work, struct snd_intelhad, hdmi_audio_wq);

	struct intel_hdmi_lpe_audio_pdata *pdata = ctx->dev->platform_data;

	struct intel_hdmi_lpe_audio_port_pdata *ppdata = &pdata->port[ctx->port];

	int ret;



	ret = pm_runtime_resume_and_get(ctx->dev);

	if (ret < 0)

		return;



	pm_runtime_get_sync(ctx->dev);

	mutex_lock(&ctx->mutex);

	if (ppdata->pipe < 0) {

		dev_dbg(ctx->dev, "%s: Event: HAD_NOTIFY_HOT_UNPLUG : port = %d\n",