Commit bb2ca6b3 authored Oct 26, 2021 by Quinn Tran Committed by Martin K. Petersen Oct 26, 2021

scsi: qla2xxx: Relogin during fabric disturbance

For RSCN of type "Area, Domain, or Fabric", which indicate a portion or
entire fabric was disturbed, current driver does not set the scan_need flag
to indicate a session was affected by the disturbance. This in turn can
lead to I/O timeout and delay of relogin. Hence initiate relogin in the
event of fabric disturbance.

Link: https://lore.kernel.org/r/20211026115412.27691-2-njavali@marvell.com

Fixes: 1560bafd ("scsi: qla2xxx: Use complete switch scan for RSCN events")
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 2c2934c8

drivers/scsi/qla2xxx/qla_init.c

+45 −9

Original line number	Diff line number	Diff line
		@@ -1786,6 +1786,8 @@ void qla2x00_handle_rscn(scsi_qla_host_t vha, struct event_arg ea)
		fc_port_t *fcport;
		unsigned long flags;

		switch (ea->id.b.rsvd_1) {
		case RSCN_PORT_ADDR:
		fcport = qla2x00_find_fcport_by_nportid(vha, &ea->id, 1);
		if (fcport) {
		if (fcport->flags & FCF_FCP2_DEVICE) {
		@@ -1797,6 +1799,40 @@ void qla2x00_handle_rscn(scsi_qla_host_t vha, struct event_arg ea)
		fcport->scan_needed = 1;
		fcport->rscn_gen++;
		}
		break;
		case RSCN_AREA_ADDR:
		list_for_each_entry(fcport, &vha->vp_fcports, list) {
		if (fcport->flags & FCF_FCP2_DEVICE)
		continue;

		if ((ea->id.b24 & 0xffff00) == (fcport->d_id.b24 & 0xffff00)) {
		fcport->scan_needed = 1;
		fcport->rscn_gen++;
		}
		}
		break;
		case RSCN_DOM_ADDR:
		list_for_each_entry(fcport, &vha->vp_fcports, list) {
		if (fcport->flags & FCF_FCP2_DEVICE)
		continue;

		if ((ea->id.b24 & 0xff0000) == (fcport->d_id.b24 & 0xff0000)) {
		fcport->scan_needed = 1;
		fcport->rscn_gen++;
		}
		}
		break;
		case RSCN_FAB_ADDR:
		default:
		list_for_each_entry(fcport, &vha->vp_fcports, list) {
		if (fcport->flags & FCF_FCP2_DEVICE)
		continue;

		fcport->scan_needed = 1;
		fcport->rscn_gen++;
		}
		break;
		}

		spin_lock_irqsave(&vha->work_lock, flags);
		if (vha->scan.scan_flags == 0) {