Commit bb14bfc7 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net: lan966x: fix a IS_ERR() vs NULL check in lan966x_create_targets() 



The devm_ioremap() function does not return error pointers.  It returns
NULL.

Fixes: db8bcaad ("net: lan966x: add the basic lan966x driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarHoratiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6882b8f

drivers/net/ethernet/microchip/lan966x/lan966x_main.c

+2 −2
Original line number Diff line number Diff line
@@ -83,10 +83,10 @@ static int lan966x_create_targets(struct platform_device *pdev, 
		begin[idx] = devm_ioremap(&pdev->dev,

					  iores[idx]->start,

					  resource_size(iores[idx]));

		if (IS_ERR(begin[idx])) {

		if (!begin[idx]) {

			dev_err(&pdev->dev, "Unable to get registers: %s\n",

				iores[idx]->name);

			return PTR_ERR(begin[idx]);

			return -ENOMEM;

		}

	}