Commit bafa23b6 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Thierry Reding
Browse files

pwm: meson: remove not needed check in meson_pwm_calc 



period >= duty implies that cnt >= duty_cnt. We verified before
that cnt <= 0xffff, therefore we can omit the check here.

Suggested-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 87a2cbf0

drivers/pwm/pwm-meson.c

+0 −5
Original line number Diff line number Diff line
@@ -204,12 +204,7 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, 
		channel->hi = 0;

		channel->lo = cnt;

	} else {

		/* Then check is we can have the duty with the same pre_div */

		duty_cnt = div64_u64(fin_freq * duty, NSEC_PER_SEC * (pre_div + 1));

		if (duty_cnt > 0xffff) {

			dev_err(meson->chip.dev, "unable to get duty cycle\n");

			return -EINVAL;

		}



		dev_dbg(meson->chip.dev, "duty=%llu pre_div=%u duty_cnt=%u\n",

			duty, pre_div, duty_cnt);