Commit bae4c0c1 authored May 04, 2021 by Khaled ROMDHANI Committed by Steve French May 04, 2021

fs/cifs: Fix resource leak



The -EIO error return path is leaking memory allocated
to page. Fix this by moving the allocation block after
the check of cifs_forced_shutdown.

Addresses-Coverity: ("Resource leak")
Fixes: 087f757b ("cifs: add shutdown support")
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 78c09634

fs/cifs/link.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -683,12 +683,16 @@ cifs_symlink(struct user_namespace mnt_userns, struct inode inode,
		struct tcon_link *tlink;
		struct cifs_tcon *pTcon;
		const char *full_path;
		void *page = alloc_dentry_path();
		void *page;
		struct inode *newinode = NULL;

		if (unlikely(cifs_forced_shutdown(cifs_sb)))
		return -EIO;

		page = alloc_dentry_path();
		if (!page)
		return -ENOMEM;

		xid = get_xid();

		tlink = cifs_sb_tlink(cifs_sb);