Commit baa75afd authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: target: Shorten ALUA error messages 

Do not print tg_pt_gp->tg_pt_gp_valid_id if we already know that it is zero.

Link: https://lore.kernel.org/r/20210415220826.29438-20-bvanassche@acm.org


Cc: Mike Christie <michael.christie@oracle.com>
Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e15c7452

drivers/target/target_core_configfs.c

+3 −8
Original line number Diff line number Diff line
@@ -2745,8 +2745,7 @@ static ssize_t target_tg_pt_gp_alua_access_state_store(struct config_item *item, 
	int new_state, ret;



	if (!tg_pt_gp->tg_pt_gp_valid_id) {

		pr_err("Unable to do implicit ALUA on non valid"

			" tg_pt_gp ID: %hu\n", tg_pt_gp->tg_pt_gp_valid_id);

		pr_err("Unable to do implicit ALUA on invalid tg_pt_gp ID\n");

		return -EINVAL;

	}

	if (!target_dev_configured(dev)) {
@@ -2797,9 +2796,7 @@ static ssize_t target_tg_pt_gp_alua_access_status_store( 
	int new_status, ret;



	if (!tg_pt_gp->tg_pt_gp_valid_id) {

		pr_err("Unable to do set ALUA access status on non"

			" valid tg_pt_gp ID: %hu\n",

			tg_pt_gp->tg_pt_gp_valid_id);

		pr_err("Unable to set ALUA access status on invalid tg_pt_gp ID\n");

		return -EINVAL;

	}
@@ -2852,9 +2849,7 @@ static ssize_t target_tg_pt_gp_alua_support_##_name##_store( \ 
	int ret;							\

									\

	if (!t->tg_pt_gp_valid_id) {					\

		pr_err("Unable to do set " #_name " ALUA state on non"	\

		       " valid tg_pt_gp ID: %hu\n",			\

		       t->tg_pt_gp_valid_id);				\

		pr_err("Unable to set " #_name " ALUA state on invalid tg_pt_gp ID\n"); \

		return -EINVAL;						\

	}								\

									\