Commit baa3afb3 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

mt76: connac: always check return value from mt76_connac_mcu_alloc_wtbl_req 



Even if this is not a real bug since mt76_connac_mcu_alloc_wtbl_req routine
can fails just if nskb is NULL , always check return value from
mt76_connac_mcu_alloc_wtbl_req in order to avoid possible future
mistake.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 4b36cc6b

drivers/net/wireless/mediatek/mt76/mt7615/mcu.c

+3 −0
Original line number Diff line number Diff line
@@ -1040,6 +1040,9 @@ mt7615_mcu_sta_ba(struct mt7615_dev *dev, 


	wtbl_hdr = mt76_connac_mcu_alloc_wtbl_req(&dev->mt76, &msta->wcid,

						  WTBL_SET, sta_wtbl, &skb);

	if (IS_ERR(wtbl_hdr))

		return PTR_ERR(wtbl_hdr);



	mt76_connac_mcu_wtbl_ba_tlv(&dev->mt76, skb, params, enable, tx,

				    sta_wtbl, wtbl_hdr);

drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c

+3 −0
Original line number Diff line number Diff line
@@ -833,6 +833,9 @@ int mt76_connac_mcu_add_sta_cmd(struct mt76_phy *phy, 
	wtbl_hdr = mt76_connac_mcu_alloc_wtbl_req(dev, wcid,

						  WTBL_RESET_AND_SET,

						  sta_wtbl, &skb);

	if (IS_ERR(wtbl_hdr))

		return PTR_ERR(wtbl_hdr);



	if (enable) {

		mt76_connac_mcu_wtbl_generic_tlv(dev, skb, vif, sta, sta_wtbl,

						 wtbl_hdr);