Commit baa00119 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

selftests: tls: clean up uninitialized warnings 



A bunch of tests uses uninitialized stack memory as random
data to send. This is harmless but generates compiler warnings.
Explicitly init the buffers with random data.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Acked-by: default avatarVadim Fedorenko <vfedorenko@novek.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent adc2e56e

tools/testing/selftests/net/tls.c

+20 −0
Original line number Diff line number Diff line
@@ -25,6 +25,18 @@ 
#define TLS_PAYLOAD_MAX_LEN 16384

#define SOL_TLS 282



static void memrnd(void *s, size_t n)

{

	int *dword = s;

	char *byte;



	for (; n >= 4; n -= 4)

		*dword++ = rand();

	byte = (void *)dword;

	while (n--)

		*byte++ = rand();

}



FIXTURE(tls_basic)

{

	int fd, cfd;
@@ -308,6 +320,8 @@ TEST_F(tls, recv_max) 
	char recv_mem[TLS_PAYLOAD_MAX_LEN];

	char buf[TLS_PAYLOAD_MAX_LEN];



	memrnd(buf, sizeof(buf));



	EXPECT_GE(send(self->fd, buf, send_len, 0), 0);

	EXPECT_NE(recv(self->cfd, recv_mem, send_len, 0), -1);

	EXPECT_EQ(memcmp(buf, recv_mem, send_len), 0);
@@ -588,6 +602,8 @@ TEST_F(tls, recvmsg_single_max) 
	struct iovec vec;

	struct msghdr hdr;



	memrnd(send_mem, sizeof(send_mem));



	EXPECT_EQ(send(self->fd, send_mem, send_len, 0), send_len);

	vec.iov_base = (char *)recv_mem;

	vec.iov_len = TLS_PAYLOAD_MAX_LEN;
@@ -610,6 +626,8 @@ TEST_F(tls, recvmsg_multiple) 
	struct msghdr hdr;

	int i;



	memrnd(buf, sizeof(buf));



	EXPECT_EQ(send(self->fd, buf, send_len, 0), send_len);

	for (i = 0; i < msg_iovlen; i++) {

		iov_base[i] = (char *)malloc(iov_len);
@@ -634,6 +652,8 @@ TEST_F(tls, single_send_multiple_recv) 
	char send_mem[TLS_PAYLOAD_MAX_LEN * 2];

	char recv_mem[TLS_PAYLOAD_MAX_LEN * 2];



	memrnd(send_mem, sizeof(send_mem));



	EXPECT_GE(send(self->fd, send_mem, total_len, 0), 0);

	memset(recv_mem, 0, total_len);