Commit ba988903 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Theodore Ts'o
Browse files

ext4: remove the access_ok() check in ext4_ioctl_get_es_cache 



access_ok just checks we are fed a proper user pointer.  We also do that
in copy_to_user itself, so no need to do this early.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarRitesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20200523073016.2944131-10-hch@lst.de


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent c7d216e8

fs/ext4/ioctl.c

+0 −5
Original line number Diff line number Diff line
@@ -754,11 +754,6 @@ static int ext4_ioctl_get_es_cache(struct file *filp, unsigned long arg) 
	fieinfo.fi_extents_max = fiemap.fm_extent_count;

	fieinfo.fi_extents_start = ufiemap->fm_extents;



	if (fiemap.fm_extent_count != 0 &&

	    !access_ok(fieinfo.fi_extents_start,

		       fieinfo.fi_extents_max * sizeof(struct fiemap_extent)))

		return -EFAULT;



	error = ext4_get_es_cache(inode, &fieinfo, fiemap.fm_start,

			fiemap.fm_length);

	fiemap.fm_flags = fieinfo.fi_flags;