Commit ba8ca097 authored by Varun Prakash's avatar Varun Prakash Committed by Martin K. Petersen
Browse files

scsi: cxgb4i: Remove an unnecessary NULL check for 'cconn' pointer 

'cconn' will never be NULL in cxgbi_conn_alloc_pdu() so remove NULL check.

Link: https://lore.kernel.org/r/1594741751-3323-1-git-send-email-varun@chelsio.com


Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarVarun Prakash <varun@chelsio.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent bc2736e9

drivers/scsi/cxgbi/libcxgbi.c

+1 −1
Original line number Diff line number Diff line
@@ -1889,7 +1889,7 @@ int cxgbi_conn_alloc_pdu(struct iscsi_task *task, u8 op) 
	struct iscsi_tcp_conn *tcp_conn = conn->dd_data;

	struct cxgbi_conn *cconn = tcp_conn->dd_data;

	struct cxgbi_device *cdev = cconn->chba->cdev;

	struct cxgbi_sock *csk = (cconn && cconn->cep) ? cconn->cep->csk : NULL;

	struct cxgbi_sock *csk = cconn->cep ? cconn->cep->csk : NULL;

	struct iscsi_tcp_task *tcp_task = task->dd_data;

	struct cxgbi_task_data *tdata = iscsi_task_cxgbi_data(task);

	struct scsi_cmnd *sc = task->sc;