Commit ba809007 authored by Kevin Wang's avatar Kevin Wang Committed by Alex Deucher
Browse files

drm/amdgpu: optimize code about format string in gfx_v10_0_init_microcode() 



the memset() and snprintf() is not necessary.

Signed-off-by: default avatarKevin Wang <kevin1.wang@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2b8f7318

drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c

+2 −3
Original line number Diff line number Diff line
@@ -3931,7 +3931,7 @@ static int gfx_v10_0_init_microcode(struct amdgpu_device *adev) 
{

	const char *chip_name;

	char fw_name[40];

	char wks[10];

	char *wks = "";

	int err;

	struct amdgpu_firmware_info *info = NULL;

	const struct common_firmware_header *header = NULL;
@@ -3944,7 +3944,6 @@ static int gfx_v10_0_init_microcode(struct amdgpu_device *adev) 


	DRM_DEBUG("\n");



	memset(wks, 0, sizeof(wks));

	switch (adev->asic_type) {

	case CHIP_NAVI10:

		chip_name = "navi10";
@@ -3953,7 +3952,7 @@ static int gfx_v10_0_init_microcode(struct amdgpu_device *adev) 
		chip_name = "navi14";

		if (!(adev->pdev->device == 0x7340 &&

		      adev->pdev->revision != 0x00))

			snprintf(wks, sizeof(wks), "_wks");

			wks = "_wks";

		break;

	case CHIP_NAVI12:

		chip_name = "navi12";