Commit ba6ea77d authored by Liao Chang's avatar Liao Chang Committed by Viresh Kumar
Browse files

cpufreq: Prefer to print cpuid in MIN/MAX QoS register error message 



When a cpufreq_policy is allocated, the cpus, related_cpus and real_cpus
of policy are still unset. Therefore, it is preferable to print the
passed 'cpu' parameter instead of a empty 'cpus' cpumask in error
message when registering MIN/MAX QoS notifier fails.

Signed-off-by: default avatarLiao Chang <liaochang1@huawei.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent d3dec5bb

drivers/cpufreq/cpufreq.c

+4 −4
Original line number Diff line number Diff line
@@ -1234,16 +1234,16 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) 
	ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MIN,

				    &policy->nb_min);

	if (ret) {

		dev_err(dev, "Failed to register MIN QoS notifier: %d (%*pbl)\n",

			ret, cpumask_pr_args(policy->cpus));

		dev_err(dev, "Failed to register MIN QoS notifier: %d (CPU%u)\n",

			ret, cpu);

		goto err_kobj_remove;

	}



	ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MAX,

				    &policy->nb_max);

	if (ret) {

		dev_err(dev, "Failed to register MAX QoS notifier: %d (%*pbl)\n",

			ret, cpumask_pr_args(policy->cpus));

		dev_err(dev, "Failed to register MAX QoS notifier: %d (CPU%u)\n",

			ret, cpu);

		goto err_min_qos_notifier;

	}