Commit ba57ee09 authored by Li Qiong's avatar Li Qiong Committed by Pablo Neira Ayuso
Browse files

ipvs: add a 'default' case in do_ip_vs_set_ctl() 



It is better to return the default switch case with
'-EINVAL', in case new commands are added. otherwise,
return a uninitialized value of ret.

Signed-off-by: default avatarLi Qiong <liqiong@nfschina.com>
Reviewed-by: default avatarSimon Horman <horms@verge.net.au>
Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 5fb45f95

net/netfilter/ipvs/ip_vs_ctl.c

+5 −0
Original line number Diff line number Diff line
@@ -2590,6 +2590,11 @@ do_ip_vs_set_ctl(struct sock *sk, int cmd, sockptr_t ptr, unsigned int len) 
		break;

	case IP_VS_SO_SET_DELDEST:

		ret = ip_vs_del_dest(svc, &udest);

		break;

	default:

		WARN_ON_ONCE(1);

		ret = -EINVAL;

		break;

	}



  out_unlock: