Commit ba530fea authored Oct 13, 2021 by Jakub Kicinski

ethernet: remove random_ether_addr()



random_ether_addr() was the original name of the helper which
was kept for backward compatibility (?) after the rename in
commit 0a4dd594 ("etherdevice: Rename random_ether_addr
to eth_random_addr").

We have a single random_ether_addr() caller left in tree
while there are 70 callers of eth_random_addr().
Time to drop this define.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20211013205450.328092-1-kuba@kernel.org


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 2b4731b1

drivers/net/ethernet/ti/am65-cpsw-nuss.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1918,7 +1918,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
		port->port_id,
		port->slave.mac_addr);
		if (!is_valid_ether_addr(port->slave.mac_addr)) {
		random_ether_addr(port->slave.mac_addr);
		eth_random_addr(port->slave.mac_addr);
		dev_err(dev, "Use random MAC address\n");
		}
		}

include/linux/etherdevice.h

+0 −2

Original line number	Diff line number	Diff line
		@@ -234,8 +234,6 @@ static inline void eth_random_addr(u8 *addr)
		addr[0] \|= 0x02; /* set local assignment bit (IEEE802) */
		}

		#define random_ether_addr(addr) eth_random_addr(addr)

		/**
		* eth_broadcast_addr - Assign broadcast address
		* @addr: Pointer to a six-byte array containing the Ethernet address