Commit ba52eddc authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: drop useless check 



Currently, the ISR check if bus->core is not NULL. But, it is a useless
check. bus->core is initialiased before to request IRQ and it is not
assigned to NULL when it is released.

Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200505123757.39506-5-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 832cc981

drivers/staging/wfx/bus_sdio.c

+1 −8
Original line number Diff line number Diff line
@@ -91,20 +91,13 @@ static void wfx_sdio_irq_handler(struct sdio_func *func) 
{

	struct wfx_sdio_priv *bus = sdio_get_drvdata(func);



	if (bus->core)

	wfx_bh_request_rx(bus->core);

	else

		WARN(!bus->core, "race condition in driver init/deinit");

}



static irqreturn_t wfx_sdio_irq_handler_ext(int irq, void *priv)

{

	struct wfx_sdio_priv *bus = priv;



	if (!bus->core) {

		WARN(!bus->core, "race condition in driver init/deinit");

		return IRQ_NONE;

	}

	sdio_claim_host(bus->func);

	wfx_bh_request_rx(bus->core);

	sdio_release_host(bus->func);

drivers/staging/wfx/bus_spi.c

+0 −4
Original line number Diff line number Diff line
@@ -140,10 +140,6 @@ static irqreturn_t wfx_spi_irq_handler(int irq, void *priv) 
{

	struct wfx_spi_priv *bus = priv;



	if (!bus->core) {

		WARN(!bus->core, "race condition in driver init/deinit");

		return IRQ_NONE;

	}

	queue_work(system_highpri_wq, &bus->request_rx);

	return IRQ_HANDLED;

}