Unverified Commit ba499a50 authored by Zhen Lei's avatar Zhen Lei Committed by Mark Brown
Browse files

regulator: userspace-consumer: use DEVICE_ATTR_RO/RW macro 



Use DEVICE_ATTR_RO/RW macro helper instead of plain DEVICE_ATTR, which
makes the code a bit shorter and easier to read.

Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210602080526.11117-1-thunder.leizhen@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent de20b747

drivers/regulator/userspace-consumer.c

+7 −7
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ struct userspace_consumer_data { 
	struct regulator_bulk_data *supplies;

};



static ssize_t reg_show_name(struct device *dev,

static ssize_t name_show(struct device *dev,

			 struct device_attribute *attr, char *buf)

{

	struct userspace_consumer_data *data = dev_get_drvdata(dev);
@@ -37,7 +37,7 @@ static ssize_t reg_show_name(struct device *dev, 
	return sprintf(buf, "%s\n", data->name);

}



static ssize_t reg_show_state(struct device *dev,

static ssize_t state_show(struct device *dev,

			  struct device_attribute *attr, char *buf)

{

	struct userspace_consumer_data *data = dev_get_drvdata(dev);
@@ -48,7 +48,7 @@ static ssize_t reg_show_state(struct device *dev, 
	return sprintf(buf, "disabled\n");

}



static ssize_t reg_set_state(struct device *dev, struct device_attribute *attr,

static ssize_t state_store(struct device *dev, struct device_attribute *attr,

			   const char *buf, size_t count)

{

	struct userspace_consumer_data *data = dev_get_drvdata(dev);
@@ -87,8 +87,8 @@ static ssize_t reg_set_state(struct device *dev, struct device_attribute *attr, 
	return count;

}



static DEVICE_ATTR(name, 0444, reg_show_name, NULL);

static DEVICE_ATTR(state, 0644, reg_show_state, reg_set_state);

static DEVICE_ATTR_RO(name);

static DEVICE_ATTR_RW(state);



static struct attribute *attributes[] = {

	&dev_attr_name.attr,