Commit ba304151 authored by Daniel Gabay's avatar Daniel Gabay Committed by Johannes Berg
Browse files

wifi: iwlwifi: yoyo: Fix possible division by zero 



Don't allow buffer allocation TLV with zero req_size since it
leads later to division by zero in iwl_dbg_tlv_alloc_fragments().
Also, NPK/SRAM locations are allowed to have zero buffer req_size,
don't discard them.

Fixes: a9248de4 ("iwlwifi: dbg_ini: add TLV allocation new API support")
Signed-off-by: default avatarDaniel Gabay <daniel.gabay@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230413213309.5d6688ed74d8.I5c2f3a882b50698b708d54f4524dc5bdf11e3d32@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 11195ab0

drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c

+6 −0
Original line number Diff line number Diff line
@@ -138,6 +138,12 @@ static int iwl_dbg_tlv_alloc_buf_alloc(struct iwl_trans *trans, 
	    alloc_id != IWL_FW_INI_ALLOCATION_ID_DBGC1)

		goto err;



	if (buf_location == IWL_FW_INI_LOCATION_DRAM_PATH &&

	    alloc->req_size == 0) {

		IWL_ERR(trans, "WRT: Invalid DRAM buffer allocation requested size (0)\n");

		return -EINVAL;

	}



	trans->dbg.fw_mon_cfg[alloc_id] = *alloc;



	return 0;