Commit ba25d181 authored by Naveen Naidu's avatar Naveen Naidu Committed by Bjorn Helgaas
Browse files

PCI: rockchip-host: Drop error data fabrication when config read fails 

If config pci_ops.read() methods return failure, the PCI_OP_READ() and
PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the
data value, so there's no need to set it in the pci_ops.read() methods
themselves.

Drop the unnecessary data value fabrication when pci_ops.read() fails.

Link: https://lore.kernel.org/r/50f9a6fa16521a86cb24d2f27c1f66eb3568cb9a.1637243717.git.naveennaidu479@gmail.com


Signed-off-by: default avatarNaveen Naidu <naveennaidu479@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 3741f5f4

drivers/pci/controller/pcie-rockchip-host.c

+1 −3
Original line number Diff line number Diff line
@@ -221,10 +221,8 @@ static int rockchip_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, 
{

	struct rockchip_pcie *rockchip = bus->sysdata;



	if (!rockchip_pcie_valid_device(rockchip, bus, PCI_SLOT(devfn))) {

		*val = 0xffffffff;

	if (!rockchip_pcie_valid_device(rockchip, bus, PCI_SLOT(devfn)))

		return PCIBIOS_DEVICE_NOT_FOUND;

	}



	if (pci_is_root_bus(bus))

		return rockchip_pcie_rd_own_conf(rockchip, where, size, val);