Commit ba195d9f authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Andrew Morton
Browse files

hfs: remove ->writepage 

->writepage is a very inefficient method to write back data, and only
used through write_cache_pages or a a fallback when no ->migrate_folio
method is present.

Set ->migrate_folio to the generic buffer_head based helper, and stop
wiring up ->writepage for hfs_aops.

Link: https://lkml.kernel.org/r/20221202102644.770505-4-hch@lst.de


Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent ee649af0

fs/hfs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -173,12 +173,12 @@ const struct address_space_operations hfs_aops = { 
	.dirty_folio	= block_dirty_folio,

	.invalidate_folio = block_invalidate_folio,

	.read_folio	= hfs_read_folio,

	.writepage	= hfs_writepage,

	.write_begin	= hfs_write_begin,

	.write_end	= generic_write_end,

	.bmap		= hfs_bmap,

	.direct_IO	= hfs_direct_IO,

	.writepages	= hfs_writepages,

	.migrate_folio	= buffer_migrate_folio,

};



/*