Commit ba0bb2ac authored by Thinh Nguyen's avatar Thinh Nguyen Committed by Wentao Guan
Browse files

usb: gadget: f_tcm: Don't free command immediately 

stable inclusion
from stable-v6.6.76
commit 16907219ad6763f401700e1b57b2da4f3e07f047
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IBW08Q

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=16907219ad6763f401700e1b57b2da4f3e07f047



--------------------------------

commit c225d006a31949d673e646d585d9569bc28feeb9 upstream.

Don't prematurely free the command. Wait for the status completion of
the sense status. It can be freed then. Otherwise we will double-free
the command.

Fixes: cff834c1 ("usb-gadget/tcm: Convert to TARGET_SCF_ACK_KREF I/O krefs")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/ae919ac431f16275e05ec819bdffb3ac5f44cbe1.1733876548.git.Thinh.Nguyen@synopsys.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 16907219ad6763f401700e1b57b2da4f3e07f047)
Signed-off-by: default avatarWentao Guan <guanwentao@uniontech.com>
parent 57a89a85

drivers/usb/gadget/function/f_tcm.c

+0 −2
Original line number Diff line number Diff line
@@ -1066,7 +1066,6 @@ static void usbg_cmd_work(struct work_struct *work) 
out:

	transport_send_check_condition_and_sense(se_cmd,

			TCM_UNSUPPORTED_SCSI_OPCODE, 1);

	transport_generic_free_cmd(&cmd->se_cmd, 0);

}



static struct usbg_cmd *usbg_get_cmd(struct f_uas *fu,
@@ -1195,7 +1194,6 @@ static void bot_cmd_work(struct work_struct *work) 
out:

	transport_send_check_condition_and_sense(se_cmd,

				TCM_UNSUPPORTED_SCSI_OPCODE, 1);

	transport_generic_free_cmd(&cmd->se_cmd, 0);

}



static int bot_submit_command(struct f_uas *fu,